-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(dynamic-plugins): add frontend docs #716
Conversation
|
5d0dd88
to
addd8a8
Compare
Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
addd8a8
to
3412c72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with 1 question and 1 suggestion
module: CustomModule # optional, same as key in `scalprum.exposedModules` key in plugin's `package.json` | ||
importName: FooPluginPage # optional, actual component name that should be rendered | ||
menuItem: # optional, allows you to populate main sidebar navigation | ||
icon: Storage # MUI4 icon to render in the sidebar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there the ability to use a provided icon (not MUI-standard) ?
Co-authored-by: David Festal <dfestal@redhat.com> Co-authored-by: Nick Boldt <nboldt@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skimmed and did some language review; looks OK to me.
probably more language tweaks could be done but until @hmanwani-rh can get 👀 on it, I think it's probably OK to merge as is and be cleaned up later if/when we're downstreaming this into one of the RHDH user / admin guides
/test |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Description
Documentation to #700
Which issue(s) does this PR fix
Part of #442
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer